cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

fix: Read-only slider fixes #2436

Open georgylobko opened 3 days ago

georgylobko commented 3 days ago

Description

Follow up the recent release of read-only states.

  1. Fix read-only slider size
  2. Prevent hover, focus, and active styles from being applied to the disabled state

Related links, issue #, if available: n/a

How has this been tested?

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.65%. Comparing base (dba9901) to head (b51f69d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2436 +/- ## ======================================= Coverage 95.65% 95.65% ======================================= Files 722 722 Lines 19338 19338 Branches 6499 6457 -42 ======================================= Hits 18497 18497 + Misses 833 787 -46 - Partials 8 54 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

katiegeorge commented 3 days ago

Looking at the deployment, the size of the handle is still smaller in the read-only state than the rest of the slider variants.

image

katiegeorge commented 2 days ago

Looking at the deployment, the size of the handle is still smaller in the read-only state than the rest of the slider variants.

image

Discussed with design - this is expected behavior (due to an accessibility concern)