codecov[bot]
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.80%. Comparing base (
df2a8b4) to head (644a37b). Report is 5 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #2605 +/- ## ======================================= Coverage 95.80% 95.80% ======================================= Files 742 742 Lines 20320 20322 +2 Branches 6859 6907 +48 ======================================= + Hits 19467 19469 +2 - Misses 797 845 +48 + Partials 56 8 -48 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Adding ariaLabel property to button dropdown items so that the announced content can be different from the visible content. That is needed here: https://github.com/cloudscape-design/components/pull/2602. Context: for visible content such as "Add filter Label = Value" need to announce "Add filter Label equals Value" because the symbolic operators are not announced correctly.
How has this been tested?
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.