cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.34k stars 152 forks source link

feat: Update toolbar layout so it spans full page width (non-deduplicated) #2624

Closed jkuelz closed 1 month ago

jkuelz commented 1 month ago

Description

Adjust the orientation of the toolbar so it is positioned above the drawers to support the asks from Sidecar team. This commit also adds a divider between the split panel and the other drawers.

Before

Screenshot 2024-08-27 at 8 53 07 PM

After

Screenshot 2024-08-27 at 8 53 29 PM

Related links, issue #, if available: n/a

How has this been tested?

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.79%. Comparing base (1b116ce) to head (d09e3b5). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2624 +/- ## ======================================== Coverage 95.78% 95.79% ======================================== Files 743 743 Lines 20380 20404 +24 Branches 6882 6571 -311 ======================================== + Hits 19522 19546 +24 - Misses 802 850 +48 + Partials 56 8 -48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.