cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.38k stars 156 forks source link

chore: Property filter token groups internal feature #2627

Closed pan-kot closed 2 months ago

pan-kot commented 2 months ago

Description

Introducing property filter token groups as an internal feature first.

Depends on https://github.com/cloudscape-design/collection-hooks/pull/74

Rel: [qUFhApKfmWEg]

How has this been tested?

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 99.17355% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.79%. Comparing base (ca81699) to head (39961ee). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/property-filter/utils.ts 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2627 +/- ## ========================================== - Coverage 95.81% 95.79% -0.03% ========================================== Files 743 743 Lines 20469 20525 +56 Branches 6595 6618 +23 ========================================== + Hits 19612 19661 +49 - Misses 849 856 +7 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.