search

cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.38k stars 156 forks source link

chore: Fix incorrect import #2628

Closed just-boris closed 2 months ago

just-boris commented 2 months ago

Description

Fixing widgetization issue. breadcrumb-group/implementation contains the pure (non-widgetized) component. Using breadcrumb-group/internal loaded the widgetized breadcrumbs which were running another loop of widgetization inside the already widgetized app layout toolbar.

Fixing the import removes some unnecessary side effects

Related links, issue #, if available: n/a

How has this been tested?

PR build. This test suite will capture possible issues

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.79%. Comparing base (69e8ea8) to head (3f947bb). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2628 +/- ## ======================================== Coverage 95.79% 95.79% ======================================== Files 743 743 Lines 20399 20399 Branches 6947 6568 -379 ======================================== Hits 19541 19541 - Misses 802 850 +48 + Partials 56 8 -48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.