cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.38k stars 156 forks source link

chore: adding selected prop to drawers and unit tests #2634

Closed dpitcock closed 2 months ago

dpitcock commented 2 months ago

Description

Uses the selected prop in the TriggerButton for visual refresh.

Added unit tests so this will be detected before making it to visual tests

Related links, issue #, if available: n/a

This fixes the issue the visual tests have detected, and they will pass. Follow up to https://github.com/cloudscape-design/components/pull/2594

How has this been tested?

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.81%. Comparing base (35c5363) to head (d17a1a2). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2634 +/- ## ======================================== Coverage 95.81% 95.81% ======================================== Files 743 743 Lines 20431 20431 Branches 6590 6913 +323 ======================================== Hits 19575 19575 + Misses 848 800 -48 - Partials 8 56 +48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.