cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.34k stars 152 forks source link

feat: Filter options in Content Display Options #2644

Closed E-Kaese closed 5 days ago

E-Kaese commented 1 month ago

Description

Original ticket ID: AWSUI-22334

This PR adds the support for filtering down the options in the content display options in collection preferences. The reordering gets disabled when a search starts and the drag handles show the disabled state.

There are 1 new property and a set of i18n strings to support this change:

columnFiltering?: boolean;
i18nStrings: {
  columnFilteringPlaceholder?: string;
  columnFilteringAriaLabel?: string;
  columnFilteringCountText?: (count: number) => string;
  columnFilteringNoMatchText?: string;
  columnFilteringClearFilterText?: string;
}

Related links, issue #, if available: n/a Original filtering request ticket

How has this been tested?

Manual and unit tests

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.15%. Comparing base (f824612) to head (09970c9). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2644 +/- ## ======================================= Coverage 96.15% 96.15% ======================================= Files 756 756 Lines 21290 21312 +22 Branches 7272 7293 +21 ======================================= + Hits 20471 20493 +22 Misses 765 765 Partials 54 54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.