Closed dpitcock closed 1 week ago
Attention: Patch coverage is 97.77778%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 95.91%. Comparing base (
093fdc0
) to head (33d1e1f
). Report is 5 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...l-refresh-toolbar/toolbar/trigger-button/index.tsx | 97.33% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note that if i blur and focus the browser again, I can get into a situation where multiple tooltips are visible:
This adds a visual tooltip to the toolbar on visual-refresh-toolbar variant by adding event listeners to the toolbar-trigger-wrapper elements that shows the tooltip when focused or hovered.
Description
The trigger-button takes new props to determine if a tooltip should be possible.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ Y - _Changes are covered with new/existing integration tests?_ YBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.