search

cloudsci / cloudmetrics

Toolkit for computing 15+ metrics characterising 2D cloud patterns
16 stars 8 forks source link

cleanup naming conv, avoid `cloud`-prefix #56

Closed leifdenby closed 2 years ago

leifdenby commented 2 years ago

Removing cloud-prefix to indicate that the functions in cloudmetrics may in fact be used for characterising any objects in 2D

NOTE: I haven't refactored iorg calculation yet because I am refactoring that code to take object-labels in https://github.com/cloudsci/cloudmetrics/pull/54

Implementing https://github.com/cloudsci/cloudmetrics/issues/47

leifdenby commented 2 years ago

Ok, all the test are passing now. If you have time for a review @martinjanssens that would be great! There might be places where I've missed the mention specifically of cloud masks and cloud objects, but I've tried to change the text and arguments to reflect that the metrics can be used on masks and objects generally.

martinjanssens commented 2 years ago

Great work here, thanks! This must have been tedious. I gave it a go and found a few more references (I left those in the iorg code alone), they are in this branch: https://github.com/martinjanssens/cloudmetrics/tree/naming-conventions-simplification-mj. I think this can be labelled finished otherwise!

leifdenby commented 2 years ago

thanks for your help on this @martinjanssens! Yes, a bit of a labour-of-love this whole thing :) We're getting there though!