Closed martinjanssens closed 1 year ago
@martinjanssens remember to update the CHANGELOG https://github.com/cloudsci/cloudmetrics/blob/master/CHANGELOG.md
Should we create a new release once we've got this merged in? Sounds like a change that will be useful for a lot of people. Following semver I think v0.3.0
would make sense since we didn't break anything and it isn't a bug fix, but a "feature" (the feature of running better and faster!)
@leifdenby yes I agree with releasing another version, potentially including Hauke's new version of the open sky function, that seems a lot quicker. Let's discuss in a new issue!
To deal with #70, I've removed the caching from
_get_regionprops
, sincecloudmetrics.mask.iorg_objects(da_cloudmask)
first does alabel_objects(da_mask)
anyway, which gives a unique array ofobject_labels
per function call, so_get_regionprops
would just make a new cache entry for these instead of reusing the cacheI've kept the legacy code, in case we want to reintroduce a cache at some point.