Closed leifdenby closed 1 year ago
Great, thanks so much @leifdenby for fixing this. The only note is that we might eventually consider updating our ci/cd pipeline so it supports the newer version of
importlib
, so we're not stuck with legacy python versions.
Yes, true. Although I think there's something upstream going wrong with pre-commit and python3.12 for now.
Another thing on importlib is that we might want to consider dropping python3.7 support since its version of importlib
doesn't have the importlib.metadata
part which can be used for retrieving package version stuff. That would allows us to clean up the setup.cfg
, setup.py
and pyproject.toml
mess too... https://docs.python.org/3.9/library/importlib.metadata.html
This PR fixes the ci/cd by:
numba
dependency tosetup.cfg
(rather thanenvironment.yml
). It also deletesenvironment.yml
and theconda
-based ci/cd setup since we don't needconda
-based dependencies, since everything ispip
-installable)python3.8
(there is some major change forimportlib
that changed withpython3.12
that was being used by default in the ci/cd pipeline)