search

cloudsidedev / appside

Multitenant environment automation.
http://cloudside.ch
GNU Affero General Public License v3.0
38 stars 7 forks source link

WordPress Config: Use https by default and/or add setting for https #95

Closed ocean90 closed 6 years ago

ocean90 commented 7 years ago

https://github.com/ttssdev/appflow/blob/8656fba970e380e3fc40ca51fb8baf0798508676/playbooks/roles/web/templates/wp_bedrock/env.j2#L17-L20

I think it's okay to just switch that to https by default. Thoughts?

ivomarino commented 7 years ago

needs to be tested I think, what exactly would this mean to WP sites?

ocean90 commented 7 years ago

Well, the site and home URL would be HTTPS.

ivomarino commented 7 years ago

Could be an issue for internal Access via localhost like wp-cron or similar, remember?

ivomarino commented 7 years ago

We should test this on dev first, IMHO.

neverything commented 6 years ago

Is this resolved? What was the solution?

ivomarino commented 6 years ago

@neverything no idea actually, the only thing I know is that in case of SSL front-end offloading all the backend communication can be done via HTTP-only.

ocean90 commented 6 years ago

You can use Dotenv::overload() to overwrite existing environment vars.

ivomarino commented 6 years ago

Issue can be closed in that case?

neverything commented 6 years ago

Yes, thanks @ocean90 and @ivomarino