Adding helm chart package support to Cloudsmith action.

cloudsmith-io / action

Github Action that uses the cloudsmith cli to interact with the Cloudsmith API (pushes, etc)

https://github.com/marketplace/actions/cloudsmith-push

MIT License

14 stars 12 forks source link

Adding helm chart package support to Cloudsmith action. #13

Closed conbon closed 3 years ago

conbon commented 3 years ago

What's Changed

This PR is opened in reference to issue #6
Added helm chart package support to cloudsmith action;
Updated readme to reflect new package support;
Updated readme examples to reflect the checkout@v2 used in the action steps.

apoclyps commented 3 years ago

Hey Conal :wave:

Thanks for your pull request. It looks good :+1:

The failing pushes are because you won't have the API_KEY for the repository in your fork. Ideally, these should only run on a merge to master so I'll update the other action's if you want to remove the branch build for Helm.

conbon commented 3 years ago

@apoclyps I think if I make the change myself to remove the branch builds, it will unblock this. Unless you want to keep them separate

apoclyps commented 3 years ago

@conbon feel free to merge/ incorporate the changes to unblock yourself

lskillen commented 3 years ago

Thanks @conbon! 🚀

I somehow missed this activity (was I off?); this looks good to me. 👍

It's a shame we can't run the tests on the PR, but it makes sense to avoid leaking the token.

🚢

conbon commented 3 years ago

Can this be merged guys? @apoclyps @lskillen

lskillen commented 3 years ago

Done! I actually thought @apoclyps had merged already. We'll release a new version on Monday to coincide with the end of Hacktoberfest. 😁👍