search

cloudsmith-io / action

Github Action that uses the cloudsmith cli to interact with the Cloudsmith API (pushes, etc)
https://github.com/marketplace/actions/cloudsmith-push
MIT License
15 stars 12 forks source link

3rd attempt: Add support for setting tags after push #35

Closed jtojnar closed 4 months ago

jtojnar commented 2 years ago

Passing --tags in extra argument does not work for version:latest for some reason so we need to do that in a separate step.

Fixes: #16

What's Changed

Incorporates fixes from #31 (but properly escaped) and #33 (without the CI change, since that requires credentials contributors won’t have).

DavidS-cloud commented 2 years ago

Thanks for your quick follow-up here. I've created an internal ticket to review and merge this, as well as improve our testing here so we don't accidentally regress other functionality again.

BartoszBlizniak commented 4 months ago

This has been implemented in latest version

jtojnar commented 4 months ago

Does it actually work with version:latest? The reason I had to implement the feature using a separate cloudsmith tags add command was because the --tags did not work properly with the virtual tag (as I discussed on 2022-05-11 with your support agent Ciara, selfoss does not use sequential versions so we have to set version:latest manually).

I guess there is/was some hook updating version:latest that triggers only after the package is pushed, so it clobbers the version:latest tag passed through --tags to push command.