cloudsmith-io / action

Github Action that uses the cloudsmith cli to interact with the Cloudsmith API (pushes, etc)
https://github.com/marketplace/actions/cloudsmith-push
MIT License
15 stars 12 forks source link

[Bug] [0.6.0] parameters with spaces break subsequent parameters #49

Closed xfranky closed 5 months ago

xfranky commented 5 months ago

Since version 0.6.0, trying to publish a package with a summary containing spaces breaks the parameters specified after the summary.

For example, this action:

      - name: Publish signature to Cloudsmith
        uses: cloudsmith-io/action@master
        with:
          api-key: <....>
          command: "push"
          format: "raw"
          owner: "<owner>"
          repo: "<repo>"
          republish: "true"
          file: "path/to/file"
          name: "name_of_the_file"
          summary: "Summary with spaces"
          version: <version>

Will produce a call to the entrypoint with:

  bash /home/runner/work/_actions/cloudsmith-io/action/master/entrypoint.sh \
[...]
  -Nnone \
  -sSummary with spaces \
  -Snone \
  -Vversion \
  -pnone \
  -- none

...with the resulting push command being executed:

cloudsmith push raw <...> --republish --name='name_of_the_file' --summary='Summary'

As a result, the version is not sent and the package is now unversioned in Cloudsmith

BartoszBlizniak commented 5 months ago

Hey @xfranky thank you for reporting this. I have a PR up and ready to fix this.

BartoszBlizniak commented 5 months ago

Hey @xfranky this should now be fixed in v0.6.6

xfranky commented 5 months ago

Great, thanks! 🎉