search

cloudsmith-io / action

Github Action that uses the cloudsmith cli to interact with the Cloudsmith API (pushes, etc)
https://github.com/marketplace/actions/cloudsmith-push
MIT License
14 stars 12 forks source link

chore(Remove need for JQ) #62

Closed BartoszBlizniak closed 3 weeks ago

BartoszBlizniak commented 3 weeks ago

What's Changed

Remove the need for JQ to be installed and use sed or awk instead to grab the latest release of the CLI. Some customers can't use 3rd party actions that are not verified, this PR should tackle this.

paddycarey commented 3 weeks ago

Does this work on MacOS runners? sed/awk may behave differently there

BartoszBlizniak commented 3 weeks ago

@paddycarey

Does this work on MacOS runners? sed/awk may behave differently there

That works on the MacOS runner but the actual entrypoint.sh doesn't: https://github.com/BartoszBlizniak/cloudsmith-githubactions-test/actions/runs/9582268941/job/26420875958#step:5:142

Not sure if we ever tested running the action on MacOS

BartoszBlizniak commented 3 weeks ago

I'm going to merge this in to unblock a customer. I will create a CENG ticket to test MacOS runner, don't think we tested that when we switched to composite.