search

cloudsoft / winrm4j

Apache License 2.0
93 stars 53 forks source link

Configure socket timeouts #108

Closed zerikv closed 4 years ago

zerikv commented 5 years ago

This PR allows to configure the two timeouts applied on the socket: for connection and read (SO_TIMEOUT).

It's desirable to be able to configure the connection timeout to avoid waiting until the TCP handshake timeout applied by the system (e.g. on Windows 21 seconds by default) for use cases where the remote host can be down. The configuration of the receive timeout is also included even it was not really necessary because a default value was already automaically calculated from the operationTimeout (by adding 1 minute).

aledsage commented 4 years ago

I'm going to create a new PR based on this one to resolve the merge conflict, and to change the default connectionTimeout to match the previous behaviour.

aledsage commented 4 years ago

I suggest we close this PR and replace it with #113 , which builds on this.

nakomis commented 4 years ago

@zerikv this has now been picked up as part of #113, so I'll close this now