search

cloudsoft / winrm4j

Apache License 2.0
93 stars 53 forks source link

Removing usage of ClientProxy.getClient #39

Closed bostko closed 7 years ago

bostko commented 8 years ago

Not tested with Https after the refactoring! One change to the behaviour: now the Http settings are used for Basic & NTLM authentications.

ahgittin commented 8 years ago

cool, i see how this can fix the error encountered in osgi

Caused by: java.lang.ClassCastException: com.sun.xml.internal.ws.client.sei.SEIStub cannot be cast to org.apache.cxf.frontend.ClientProxy
    at org.apache.cxf.frontend.ClientProxy.getClient(ClientProxy.java:128)
    at io.cloudsoft.winrm4j.client.WinRmClient.createService(WinRmClient.java:413)
ahgittin commented 8 years ago

re https, it looks like there are other changes in here around when we do the ssh config ... were they necessary due to init ordering (i'm not real familiar w the code) ? assuming so we probably do need to test https, but could be for another PR.

ahgittin commented 8 years ago

however as @neykov noted we're likely still to pull the wrong impl and that's likely to cause other problems

ahgittin commented 8 years ago

still didn't work as expected :( ... close in favour of #40 ?

neykov commented 7 years ago

Fixed in #40. Closing.