search

cloudsoft / winrm4j

Apache License 2.0
93 stars 53 forks source link

WinRmClient cleanup #54

Closed neykov closed 7 years ago

neykov commented 7 years ago

A general refactoring, no new features added. Breaks up the huge WinRmClient file into several smaller pieces. Easier reviewed by looking at the individual commits.

This has been sitting around in a giant stash since before the 0.5.0 release, but decided it's too much to include in the release. I just split it into smaller, logical commits now. Some more to follow, mostly focusing on streamlining the tests.

bostko commented 7 years ago

@neykov you deprecated methods and left io.cloudsoft.winrm4j.winrm.WinRmTool deprecated code being used. Could you update WinRmTool or provide WinRmTool alternative for https://github.com/apache/brooklyn-server

aledsage commented 7 years ago

@neykov have only had a chance for a very quick look, but it looks good - nice to split it up into more manageable classes!

neykov commented 7 years ago

@bostko addressed comments - fixed failing test case (good catch!) and removed calls to deprecated methods.

As for updating Brooklyn's wrapper - it's perfectly fine to use the existing deprecated methods, but I'll try to update it after we cut a new winrm4j release.

bostko commented 7 years ago

Tests pass. Good to merge I think.

neykov commented 7 years ago

Thanks @bostko, merged.