search

cloudsoft / winrm4j

Apache License 2.0
93 stars 53 forks source link

Missing build method authenticationScheme needed for tests #71

Closed bostko closed 5 years ago

bostko commented 7 years ago

@Graeme-Miller could you review this? Thanks.

neykov commented 7 years ago

@bostko There's already a method to set the scheme but it's called setAuthenticationScheme. No idea why, better keep the convention. +1 for the change, but can you mark the existing one as @Deprecated.

bostko commented 7 years ago

@neykov sorry, addressed your comment.

neykov commented 7 years ago

thanks @bostko, LGTM

GQsj commented 7 years ago

Is this branch not be added to the master? In my pull code, there is no method called authenticationScheme, and the AbstractWinRmToolLiveTest.java report the error message.