search

cloudsoft / winrm4j

Apache License 2.0
93 stars 53 forks source link

Method does not sets sslContext for TLSClientParameters #85

Closed maujbs closed 5 years ago

maujbs commented 6 years ago

https://github.com/cloudsoft/winrm4j/blob/facb66ca29f44a17cc9d7c11a73c0abf6f52743f/client/src/main/java/io/cloudsoft/winrm4j/client/WinRmClient.java#L288-L290

I created a SSLContext and I expected that this will be set in TLSClientParameters, however the setSslContext method is never called by initializeClientAndService. Is there a way to set it?

This issue affects the application because it is not FIPS compliant!! Because it's using the default SSLContext instead of the one created by the app.

Thanks in advance

aledsage commented 5 years ago

@maujbs thanks for reporting and the suggestion.

To clarify, do you want to set the SSLContext on the WinRmClientBuilder, and have that used by the initializeClientAndService (to call tlsClientParameters.setSslContext(sslContext);)? And/or also allow the SSLContext to be supplied via WinRmTool.Builder.sslContext()?

This is a similar (complementary) issue to https://github.com/cloudsoft/winrm4j/issues/80, where we could also call tlsClientParameters.setSSLSocketFactory(sslSocketFactory) (allowing that to be passed in via the builder).

aledsage commented 5 years ago

This has been fixed in the 0.6.1 release - you can now pass the SSLContext into the builder (see https://github.com/cloudsoft/winrm4j/pull/92).