Closed nielm closed 1 month ago
Potential fix for #318
Hello, this looks good 1) can you please document what the behavior would be if the configuration is invalid? looks like "no-op plus error log" 2) maybe there should be a metric outcome in addition to the logs outcome
Hello, this looks good
- can you please document what the behavior would be if the configuration is invalid? looks like "no-op plus error log"
- maybe there should be a metric outcome in addition to the logs outcome
yes, the poller component will detect the invalid configuration and this will result in a no-op along with:
poller/requests-failed
metricThis will happen every $polling_interval until the config is fixed.
Fully Deprecate minNodes, maxNodes from configuration
Validate the config against a JSON schema.
Add command line config validator for JSON and GKE configMaps
BREAKING CHANGE: previous configs may fail due to stricter configuration validation.