Fix some `Pos` and `End` issues on `TableConstraint`

cloudspannerecosystem / memefish

memefish is the foundation to analyze Spanner SQL

https://cloudspannerecosystem.dev/memefish/

MIT License

76 stars 19 forks source link

Closed makenowjust closed 3 weeks ago

makenowjust commented 3 weeks ago

In TableConstraint definition, comments about pos and end were missing. This PR adds them.
When ConstraintPos is missing, it sets InvalidPos explicitly.
Also, that ForeignKey and Check set expect(")").End to Rparen on parsing seems incorrect, and expect(")").Pos is correct.

Note that expect(")").End also appears in parseColumnDefOptions, but it will be removed in #142.

makenowjust commented 3 weeks ago

Thank you @apstndb.