cloudspannerecosystem / memefish

memefish is the foundation to analyze Spanner SQL
https://cloudspannerecosystem.dev/memefish/
MIT License
76 stars 19 forks source link

Implement HAVING MIN/MAX and RESPECT/IGNORE NULLS #154

Closed apstndb closed 3 weeks ago

apstndb commented 3 weeks ago

This PR implements the current aggregate function call syntax.

https://cloud.google.com/spanner/docs/reference/standard-sql/aggregate-function-calls#aggregate_function_call_syntax

function_name(
  [ DISTINCT ]
  function_arguments
  [ { IGNORE | RESPECT } NULLS ]
  [ HAVING { MAX | MIN } having_expression ]
)

Note

fix #88

apstndb commented 3 weeks ago

Conflict resolved and suggestion applied.

makenowjust commented 3 weeks ago

@apstndb Thank you!