search

cloudspannerecosystem / memefish

memefish is the foundation to analyze Spanner SQL
https://cloudspannerecosystem.dev/memefish/
MIT License
76 stars 19 forks source link

Allow using default expression in alter column #48

Closed git-hulk closed 2 years ago

git-hulk commented 2 years ago

@makenowjust Fixed

codecov-commenter commented 2 years ago

Codecov Report

Merging #48 (3c45ba7) into main (ecc16e6) will decrease coverage by 0.00%. The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   73.39%   73.38%   -0.01%     
==========================================
  Files          28       28              
  Lines        6306     6330      +24     
==========================================
+ Hits         4628     4645      +17     
- Misses       1551     1558       +7     
  Partials      127      127
Impacted Files Coverage Δ
pkg/ast/ast.go 92.85% <ø> (ø)
pkg/ast/pos.go 0.00% <0.00%> (ø)
pkg/ast/sql.go 97.36% <100.00%> (+0.02%) :arrow_up:
pkg/parser/parser.go 92.38% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecc16e6...3c45ba7. Read the comment docs.

git-hulk commented 2 years ago

@makenowjust Should I add more test cases for End function to make codecov happy?

makenowjust commented 2 years ago

@git-hulk It sounds good.