cloudspannerecosystem / memefish

memefish is the foundation to analyze Spanner SQL
https://cloudspannerecosystem.dev/memefish/
MIT License
76 stars 19 forks source link

Fix import path from `MakeNowJust/memefish` to `cloudspannerecosystem/memefish` #53

Closed makenowjust closed 1 year ago

makenowjust commented 1 year ago

Close #51

Replaced MakeNowJust/memefish with cloudspannerecosystem/memefish. In addition, we notice the migration information to README.md.

At least, the test is passed on my laptop, however, I don't know that it works correctly.

makenowjust commented 1 year ago

@nktks @tyamagu2 I haven't been using Go much lately and would like you to review this PR.

makenowjust commented 1 year ago

Codecov was disabled because I have no idea how to use codecov and similar services under this org.

Another, the workflow to deploy to GH pages does not work for now. I will fix it in another PR.

nktks commented 1 year ago

I'm not sure about import path, but it seems to work in the case go get to new module.

go get github.com/cloudspannerecosystem/memefish@59e4bb21f177ae7789a7b72435b50bd77e23fd96
go: added github.com/cloudspannerecosystem/memefish v0.0.0-20230401063640-59e4bb21f177
cat go.mod
module github.com/nktks/test

go 1.18

require github.com/cloudspannerecosystem/memefish v0.0.0-20230401063640-59e4bb21f177 // indirect
package main

import (
    "fmt"
    "log"

    "github.com/cloudspannerecosystem/memefish/pkg/parser"
    "github.com/cloudspannerecosystem/memefish/pkg/token"
)

func main() {
    p := &parser.Parser{
        Lexer: &parser.Lexer{
            File: &token.File{FilePath: "", Buffer: "SELECT 1"},
        },
    }
    s, err := p.ParseStatement()
    if err != nil {
        log.Fatal(err)
    }
    fmt.Println(s.SQL())

}
go run main.go
SELECT 1
nktks commented 1 year ago

Codecov was disabled because I have no idea how to use codecov and similar services under this org.

Maybe we need to request cloudspannerechosystem org admin to use Codecov.

@kazegusuri , @ansh0l Can we use Codecov in cloudspannerechosystem org?