search

cloudspannerecosystem / spanner-change-streams-tail

CLI to tail Cloud Spanner change streams
Apache License 2.0
20 stars 3 forks source link

change this to be built with make and goreleaser #1

Open maguec opened 1 year ago

maguec commented 1 year ago

Include a make file and a gorelaser file for easier build processing

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

yfuruyama commented 1 year ago

Hi @maguec, thank you for filing this PR.

Could you elaborate on the context of this change?

If you want to have a binary, we can use go build or GOOS=linux GOARCH=amd64 go build to build a binary for target OS. I don't think we need to let users install goreleaser to get the binary.

maguec commented 1 year ago

Make file just helps people get started quicker and goreleaser file for those who prefer it and if we want to release binaries on Github for other people who may not be able to build

yfuruyama commented 1 year ago

Thanks for your comment.

So I think there are two changes here: Makefile and Goreleaser.

For Makefile, it's mainly for developers for this project to build and test, but currently there are no complex build pipeline here. They can use idiomatic go build and go test instead of using make build and make test.

For Goreleaser, it can be used for releasing the binary for this tool, but I haven't decided yet how to distribute the binary for users who don't have go installed. This tool is supposed to be used for local development, so I assume that users are likely (or willing) to have go on their local environment.

For now I'd like to decline to merge this change, but let me consider this change again if we decide releasing binary with Goreleaser. Does that sound good for you?