search

cloudspannerecosystem / spanner-cli

Interactive command line tool for Cloud Spanner
Apache License 2.0
227 stars 29 forks source link

Update spanner library #156

Closed r3nic1e closed 6 days ago

r3nic1e commented 1 year ago

There was a bug that was fixed in v1.45.0 - https://github.com/googleapis/google-cloud-go/issues/7136 We are constantly getting this error.

Could you please release a new version with fresh spanner library?

yfuruyama commented 1 year ago

Which bug are you referring to? It looks like spanner v1.45.0 doesn't contain the commit for the fix you mentioned.

r3nic1e commented 1 year ago

Oh, I'm sorry, didn't check twice if that was really fixed. Basically I experience a lot of these errors when inserting more than 100k rows:

ERROR: spanner: code = "Aborted", desc = "Transaction aborted. Database schema probably changed during transaction, retry may succeed."

And there is nothing happening in the database other than spanner-cli inserting rows.

Increasing size of bulk insert (--bulk-size of spanner-dump) increases the chance of this error appearing.

yfuruyama commented 1 year ago

I guess it's a Spanner server side issue, not client side.

Could you confirm if the same issue happens when inserting rows with some Go program using spanner client library or gcloud command? If it happens, it must be a Spanner server side issue.

apstndb commented 1 week ago

spanner-cli already use spanner/v1.59.0 so we can close this issue. https://github.com/cloudspannerecosystem/spanner-cli/blob/a0ff8aeb68275bb97ba25aa3c6461591dd5467ae/go.mod#L7

yfuruyama commented 6 days ago

Thanks. Let me close this issue.