migrate: supports INSERT Statement

cloudspannerecosystem / wrench

wrench - Schema management tool for Cloud Spanner -

MIT License

239 stars 46 forks source link

migrate: supports INSERT Statement #109

Closed knwoop closed 4 months ago

knwoop commented 5 months ago

WHAT

support INSERT statement.

WHY

to support INSERT statement.
Currently, Cloud Spanner does not support INSERT in partitioned DML (INSERT was treated as partitioned DML in wrench)
- ref: https://cloud.google.com/spanner/docs/dml-partitioned#unsupported-features

google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

knwoop commented 4 months ago

Thank you for your PR, @knwoop, and sorry that we could not get back to you sooner 🙇 I left one minor comment, but except that it looks good to me!

@shuheiktgw Thank you for reviewing my PR! I appreciate your feedback and have addressed the comment.