search

cloudspannerecosystem / wrench

wrench - Schema management tool for Cloud Spanner -
MIT License
238 stars 47 forks source link

Add a new job for publishing docker image to GitHub Container Registry #111

Closed sters closed 3 months ago

sters commented 3 months ago

WHAT

This PR adds a new CI job for publishing docker image to GitHub Container Registry in the release workflow.

You can confirm the result on my forked repo:

WHY

To provide a continuous build for the docker image related to releases. And related to this comment: https://github.com/cloudspannerecosystem/wrench/pull/97#issuecomment-1826669157

sters commented 3 months ago

I don't know why CI is failed at Run make setup-emulator with this error:

make: *** [Makefile:25: setup-emulator] Error 56

In my forked repo, there is no problem. https://github.com/sters/wrench/actions/runs/9958721943/job/27513780866

sters commented 3 months ago

I don't know who can review on this repo... Maybe it's better to add CODEOWNER file.

Anyway, I think @shuheiktgw can do. Could you check this PR when you have time?

shuheiktgw commented 3 months ago

It seems to work great 🎉 https://github.com/cloudspannerecosystem/wrench/pkgs/container/wrench

sters commented 3 months ago

Thanks all!

Shion1305 commented 3 months ago

Thanks for implementing the workflow! I'll close #97

comebackoneyear commented 2 months ago

Would it be possible to add support for arm images? I'm using the github action runners linux/arm64/v8 but also m2 mac.