Closed halmai closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
âšī¸ Googlers: Go here for more info.
@googlebot I signed it!
@halmai
Sorry for late đ Let me review this in this week end đ
@110y
Sorry for late đ Let me review this in this week end đ
Is there any progress with this?
@halmai
So sorry for the late đ Let me check...
@halmai Thank you for your contribution!
WHAT
This PR addresses the issue https://github.com/cloudspannerecosystem/wrench/issues/47.
The bug was that if more migration scripts have the same version number then, instead of reporting this as an issue,
wrench
pretended as if everything was OK and simply ignored the later migration scripts.WHY
This bug caused me several hours of bug hunting. I hope with this PR, others will find their bug more easily.
Note: there was another minor issue reported by
golangci-lint
which I also fixed.