search

cloudspannerecosystem / wrench

wrench - Schema management tool for Cloud Spanner -
MIT License
236 stars 46 forks source link

Option to define emulator host from Config #73

Open PumpkinSeed opened 1 year ago

PumpkinSeed commented 1 year ago

WHAT

Make it possible to pass the Emulator host in the Config.

// example
cfg := wrenchSpanner.Config{
    Project:  "project",
    Instance: "instance",
    Database: "database",
    EmulatorHost: "localhost:9091",
}
spannerCli, err := wrenchSpanner.NewClient(ctx, &cfg)

WHY

Currently if we want to define an emulator host, we need to set the SPANNER_EMULATOR_HOST. Those who using the tool as library it is pretty hard to maintain, because we need to call os.Setenv, which is a pretty bad practices in case of testing.

Edit, in case of approval, I will be happy to work on it.

kazegusuri commented 1 year ago

It seems good. It's welcome to your contribution. I will review if you create a PR.