cloudspannerecosystem / wrench

wrench - Schema management tool for Cloud Spanner -
MIT License
238 stars 47 forks source link

👷 Implement CI that builds image and pushes to DockerHub #97

Closed Shion1305 closed 3 months ago

Shion1305 commented 11 months ago

I'm working at Merpay cashio team as an intern! Feel free to contact me regarding this PR :) (Slack name: @Shion(Intern) )

WHAT

Implemented GitHub Actions that build images and push them to DockerHub.

WHY

As it is discussed in #82 .

Things to be concerned

In order to make this GitHub Actions works, you have to set DOCKERHUB_USERNAME DOCKERHUB_TOKEN .

You can validate this workflow with following references.

kazegusuri commented 11 months ago

thank you for making this PR. I would like to use GitHub docker registry instead of docker hub. Can you fix to use GitHub docker registry?

Shion1305 commented 11 months ago

@kazegusuri
Thank you for your feedback! Sure, I'll be working on that 👍

However, I have a question regarding the existing official image on Docker Hub. Do you plan to maintain and update this image alongside the GitHub Docker registry version? IMO, keeping the image on Docker Hub updated and available is beneficial as long as if there are no additional costs involved.

toga4 commented 7 months ago

@kazegusuri @shion1305 Hello, any update on this PR? I would like to use the latest version of wrench as a container image and would be happy to see this PR go forward. Please let me know if there is anything I can do to help.

Shion1305 commented 3 months ago

@toga4 Sorry for not making any progress on this..! Image on GHCR is now made available by #111 , so I let this close.

toga4 commented 3 months ago

good news!