Closed raboof closed 3 years ago
I've updated the GITHUB_TOKEN env var to the token currently used for cloudstatebot, and reverted back the latest commits. But realising that the secrets will of course not be available to pull requests from forks. If we need to authenticate with secrets, then we'll likely need a different approach here, as we shouldn't enable secrets for forked pull requests.
Ok, looking at this more closely. So the older version of Graal that we use is published to docker.pkg.github.com/graalvm/container/community
but docker.pkg.github.com
requires authentication for all pulls. The newer Graal docker images are at ghcr.io/graalvm/graalvm-ce
, which allows unauthenticated pulls, but doesn't have the older version that we're using. Trying an upgrade to 20.3.1
and it doesn't build — will need changes. So possibilities as I see it:
I'm trying a minimal Graal update in #519
Closing this one, with #519 passing tests.
Great, thx!
Since they have disappeared from Docker Hub: https://www.graalvm.org/docs/getting-started/#graalvm-community-container-images
May need an update to CircleCI to set up credentials to log in to GitHub, let's see.