cloudstateio / cloudstate

Distributed State Management for Serverless
https://cloudstate.io
Apache License 2.0
763 stars 97 forks source link

Fix unsafe state access in value entity proxy #531

Closed raboof closed 3 years ago

raboof commented 3 years ago

The 'handler' parameter to 'performAction' was called from a future outside of message processing.

While it 'maybe never lead to problems in practice', accessing actor state like that is generally not allowed, and could have lead to confusing situations (e.g. misleading 'sender' parameters or actual problems when we'd refactor things later).

For this reason I didn't find a way to introduce a test that covers the problem.

ralphlaude commented 3 years ago

LGTM!