Closed marcellanz closed 4 years ago
@pvlugter I used an image repository of my own for the docker image we create for the python tck docker image in this PR. Doing this similar for the Go Support and I think Adriano is doing the same for Dart and Kotlin.
While it's fine for me for now, and the images are quite small (at least for Go :-) ) you might want to have them in the cloudstate(io) docker repo or the like at some point? This is also not urgent, as these images are not used by users usually.
LGTM. We just have to make sure that it runs after the build and after pushing the image to the repository. Which is why I would like an image that does not depend on our build because I see the shoppin-cart image as something independent. That serves as an example for the user and things like cloudstate CLI. So I find the previous docker image simpler and serving a purpose other than TCK. But I think for now we can go on like this
@pvlugter I used an image repository of my own for the docker image we create for the python tck docker image in this PR. Doing this similar for the Go Support and I think Adriano is doing the same for Dart and Kotlin.
While it's fine for me for now, and the images are quite small (at least for Go :-) ) you might want to have them in the cloudstate(io) docker repo or the like at some point? This is also not urgent, as these images are not used by users usually.
- gcr.io/mrcllnz/cloudstate-python-tck
- gcr.io/mrcllnz/cloudstate-go-tck-dev:latest
- gcr.io/mrcllnz/cloudstate-go-tck:latest
We can certainly have these published under cloudstateio on docker hub. I can create repositories and teams. Let me know docker hub usernames to give access.
@pvlugter Thank you. my docker hub handle is: mrcllnz
@marcellanz added you to python and go teams under cloudstateio org in docker hub, with access to these newly created repositories:
cloudstateio/cloudstate-python-tck
cloudstateio/cloudstate-go-tck
cloudstateio/cloudstate-go-tck-dev
@pvlugter thank you. I have pushed the relevant go-tck and python-tck images over to docker hub. TCK-nightly is updated to reflect that.
I have one thing left, I don't need the repositorycloudstateio/cloudstate-go-tck-dev
, I think we can delete it, I used it on gcr.io but can easily use a tag in the cloudstateio/cloudstate-go-tck
repository we now have.
Okay, I've deleted cloudstateio/cloudstate-go-tck-dev
This PR should fix #27 and prepare part for #28.
This PR runs the against the TCK docker images of the main project.