cloudstax / firecamp

Serverless Platform for the stateful services
https://www.cloudstax.io
Apache License 2.0
210 stars 20 forks source link

BUILD_YOUR_IMAGES wrong instructions #26

Closed jazzl0ver closed 6 years ago

jazzl0ver commented 6 years ago
1. Build your own ecs agent docker image.

Checkout cloudstax amazon-ecs-agent branch, git clone https://github.com/cloudstax/amazon-ecs-agent.git, and change the "org" in Makefile and agent/engine/f
irecamp_task_engine.go to "mydockeraccount/". Then simply 'make' to build and upload the docker image.

There's no "org" defined at all:

$ pwd
/home/user/go/src/github.com/cloudstax/amazon-ecs-agent

$ grep org Makefile agent/engine/firecamp_task_engine.go
Makefile:       go get golang.org/x/tools/cmd/cover
Makefile:       go get golang.org/x/tools/cmd/goimports

$ grep cloudstax -r *
agent/engine/firecamp_task_engine.go:// Define here again to avoid the dependency on githut.com/cloudstax/firecamp
agent/engine/firecamp_task_engine.go:   volumeDriver        = "cloudstax/firecamp-volume"
agent/engine/firecamp_task_engine.go:   logDriver           = "cloudstax/firecamp-log"
Makefile:       @docker build -f scripts/dockerfiles/Dockerfile.release -t "cloudstax/firecamp-amazon-ecs-agent:latest" .
Makefile:       @echo "Built Docker image \"cloudstax/firecamp-amazon-ecs-agent:latest\""
JuniusLuo commented 6 years ago

oops, the last commit was not pushed to github. pushed now. please pull again. thanks!

jazzl0ver commented 6 years ago

looks like it's still not pushed.. the last commit was 16 hours ago..

JuniusLuo commented 6 years ago

yes, it was committed locally at Feb 3. but not pushed. the commit was 77371c03fc57aaada7961d16ea3d64bf8e4a32a3. Please pull it.

jazzl0ver commented 6 years ago

was searching in a wrong repo. sorry.