search

cloudstax / firecamp

Serverless Platform for the stateful services
https://www.cloudstax.io
Apache License 2.0
209 stars 20 forks source link

aws quickstart template misses latest version #36

Closed jazzl0ver closed 6 years ago

jazzl0ver commented 6 years ago

https://s3.amazonaws.com/quickstart-reference/cloudstax/firecamp/latest/templates/firecamp-existingvpc.template: image

JuniusLuo commented 6 years ago

We do not want to expose the latest version to AWS QuickStart, as the latest version may not be stable. We will always put the latest release in AWS QuickStart. The QuickStart S3KeyPrefix points to AWS QuickStart S3 bucket, the path is cloudstax/firecamp/latest.

If you want to test/develop the latest version, please still use "cloudstax" bucket, https://s3.amazonaws.com/cloudstax/firecamp/releases/latest/templates/firecamp-master.template or https://s3.amazonaws.com/cloudstax/firecamp/releases/latest/templates/firecamp-existingvpc.template

jazzl0ver commented 6 years ago

Of course, it's completely up to you. But I'd give a user a choice of what to use. In my opinion the better way is to put a comment to avoid using latest release in production. Also, please recall this thread: https://github.com/cloudstax/firecamp/issues/17#issuecomment-360527241: you advised to change the QSS3KeyPrefix to 0.9.2 from latest.

JuniusLuo commented 6 years ago

Thanks for sharing your suggestion! We still have concern for including the latest version in AWS QuickStart. None other QuickStart includes the developing release. Let's add how to install the latest version into the installation guide.

JuniusLuo commented 6 years ago

Updated the installation guide for installing the latest build.

jazzl0ver commented 6 years ago

The current quick start template still uses cloudstax/firecamp/latest as S3KeyPrefix, while the release version either 0.9.3 or 0.9.2. Is that OK?

JuniusLuo commented 6 years ago

This is ok. The quickstart templates are hosted on AWS QuickStart Bucket, not cloudstax bucket. The templates in AWS QuickStart bucket has only one path, cloudstax/firecamp/latest. So the S3KeyPrefix in AWS QuickStart bucket is cloudstax/firecamp/latest. When we have a new release, the templates under cloudstax/firecamp/latest in AWS QuickStart bucket will be updated to the new release.

It is like we always put the last release (such as 0.9.3) templates under firecamp/releases/latest in the cloudstax bucket.

jazzl0ver commented 6 years ago

Oh, that makes sense. Though it's still kinda messing. For example, if a user is choosing release 0.9.2 in the dropdown, will he need to change the quickstart bucket path from latest to something else? Didn't you think to sync the AWS quick start bucket name with the release version?

JuniusLuo commented 6 years ago

Good Point! We could not change the bucket name with the release version. This is not how AWS QuickStart works. We will need to make sure both releases work on the same templates, both 0.9.3 and 0.9.2 work on the 0.9.3's templates. This is not a hard problem. The template changes are usually small and compatible between 2 releases. Just tried to deploy 0.9.2 from AWS QuickStart, and it worked.