cloudstax / firecamp

Serverless Platform for the stateful services
https://www.cloudstax.io
Apache License 2.0
208 stars 21 forks source link

update service doesn't change task definition #73

Open jazzl0ver opened 5 years ago

jazzl0ver commented 5 years ago

After issuing:

[root@host 1.0]# ./firecamp-service-cli -op=update-service -service-type=kafka -region=us-east-1 -cluster=firecamp-uat -service-name=kafka2-uat -kafka-heap-size=1024

the task definition didn't change to reflect the new heap size. Is that correct?

JuniusLuo commented 5 years ago

Updating kafka heap size does not change the task definition. It directly changes kafka heap config. And you need to restart the service for kafka to load the new heap size.

jazzl0ver commented 5 years ago

Oh.. Is the heap setting in the task definition ever used?