search

cloudtools / awacs

Python library for AWS Access Policy Language creation
BSD 2-Clause "Simplified" License
395 stars 102 forks source link

change isinstance AWSHelperFn to inspect class names #141

Closed ITProKyle closed 4 years ago

ITProKyle commented 4 years ago

This will allow for the internal awacs.AWSHelperFn class + subclasses and troposphere.AWSHelperFn class + subclasses to be used as a value for all properties enabling the use of troposphere.Ref or similar to be used.

Resolves #139.

troyready commented 4 years ago

@markpeek would you be able to re-review now?

acmcelwee commented 4 years ago

I just ran into this same issue, with trying to use a troposphere.If value for the Resource in an awacs.aws.Statement.

As I think about this more, I wonder if awacs needs a reciprocal compat.py like troposphere has. Thoughts, anyone?

EDIT I now see #55 has more discussion and workarounds that others have used for this issue.

ITProKyle commented 4 years ago

Any updates on getting this (or any other PR that addresses the issue) merged?

markpeek commented 4 years ago

Thank you for adding the test and your patience for me getting it merged.