search

cloudtools / stacker

An AWS CloudFormation Stack orchestrator/manager.
http://stacker.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
709 stars 167 forks source link

Documentation update: Adding Default Lookup to official docs #636

Closed GarisonLotus closed 6 years ago

GarisonLotus commented 6 years ago

This has been implemented since February.

GarisonLotus commented 6 years ago

@phobologic - Just an FYI, no actual code updates in this PR.

GarisonLotus commented 6 years ago

@phobologic - Troy and I just spoke about this idea, and we don't believe that this would work. Although we have not tested it, we think that stacker would throw an exception for the output lookup in your example, stoping the default fall back from completing.

I'm thinking it might be a good idea to make it more obvious that we mean "environment file" in the documentation, since that is how the feature actually was implemented.

EDIT: ok, I tested it out, yup - output lookup throws an exception, so I will update the docs to make it more obvious we are referring to environment files only.