search

cloudtools / stacker

An AWS CloudFormation Stack orchestrator/manager.
http://stacker.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
709 stars 167 forks source link

allow configs without stacks #637

Closed troyready closed 6 years ago

troyready commented 6 years ago

This relaxes the current stack validation, replacing it instead with action warning messages.

With this, configurations can be created with only hooks.

troyready commented 6 years ago

An alternative to this is just requiring a dummy stack; not sure if that's better to keep the Model more 'pure':

stacks:
  placeholderstack:
    enabled: false
    class_path: nonexistentmodule.fakeclass
phobologic commented 6 years ago

I think this should be fine - I think once we have the hooks as part of the graph, we likely won't need this :)

phobologic commented 6 years ago

@troyready can you merge master into this branch and see if it helps with the functional tests?

troyready commented 6 years ago

Sure thing; rebased and pushed.

phobologic commented 6 years ago

Ahh - I think I see what it is. The tests that used to stop because there were no stacks are now continuing on, and make calls to cloudformation. Can you mark those as requiring AWS now? There's a function for that that we use in the other tests that normally require AWS.

phobologic commented 6 years ago

Ok, merged with #640 (cleaned up the tests there, since I don't have push permissions to your repo). Thanks @troyready