search

cloudtools / stacker

An AWS CloudFormation Stack orchestrator/manager.
http://stacker.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
709 stars 167 forks source link

fix interactive_update_stack calls with empty string parameters #658

Closed troyready closed 6 years ago

troyready commented 6 years ago

PR #644 didn't account for empty string parameters

troyready commented 6 years ago

Might make sense to break out the old/new params -> dict conversions to a separate method so they can be have unit tests made?

phobologic commented 6 years ago

Yeah, definitely seems like at least the new parameter dict generator might be better as a function - it's fairly complicated for a one liner.