search

cloudtools / stacker

An AWS CloudFormation Stack orchestrator/manager.
http://stacker.readthedocs.io/en/stable/
BSD 2-Clause "Simplified" License
711 stars 167 forks source link

Pinning PyYAML to 3.13 to deal with cfn-flip pin #684

Closed phobologic closed 5 years ago

phobologic commented 5 years ago

https://github.com/awslabs/aws-cfn-template-flip/pull/54

YAML was pinned in the cfn-flip package that troposphere depends on, and without this we have issues with building.

troyready commented 5 years ago

Agreed on adding a comment about it

phobologic commented 5 years ago

Looks like the pinning isn't required anymore - this removes it now, but I've gone back to pinning boto/botocore to deal with the current issues in moto.

https://github.com/spulec/moto/issues/1924 https://github.com/spulec/moto/issues/1941

@xiaket pinging you since you had removed the pinning of boto/botocore, hopefully this doesn't lead to too many issues.

xiaket commented 5 years ago

Thanks @phobologic ! Yeah, this pinning gave us some little trouble a while back but it's all sorted out by now. Cheers.