Ensure that base64 lookup codec encodes the bytes object as a string

cloudtools / stacker

An AWS CloudFormation Stack orchestrator/manager.

http://stacker.readthedocs.io/en/stable/

BSD 2-Clause "Simplified" License

711 stars 167 forks source link

Ensure that base64 lookup codec encodes the bytes object as a string #742

Closed acmcelwee closed 5 years ago

acmcelwee commented 5 years ago

We recently updated our python runtime for stacker from 2 to 3, and using the file lookup with the base64 codec results in the output being a bytes object (b'foo...'), instead of a string that's usable as a CFN parameter or even a local stacker variable.

Fixes #693.

russellballestrini commented 5 years ago

@acmcelwee could you update https://github.com/cloudtools/stacker/blob/master/CHANGELOG.md ?

acmcelwee commented 5 years ago

@russellballestrini, thanks for the read. I added a changelog entry (with a force push to keep the commit history clean). I'll let you give it a final look before I merge it, or also feel free to merge it yourself, if it looks good to you.

russellballestrini commented 5 years ago

Looks good to me! Merge away!