Closed markpeek closed 2 years ago
markpeek
commented
2 years ago @sid21rane LabelMatchStatement is included in this PR via StatementOne, StatementTwo and StatementThree properties. These are used due to the circular definitions in WAFv2 and are implemented per AWS::WAFv2::RuleGroup Statement.
sid21rane
commented
2 years ago Thanks Mark,
Please can I request for LabelMatchStatement under StatementOne, Two and Three for AWS::WAFv2::WebACL as well.
Regards, Siddharth Rane
On Thu, 30 Dec 2021, 21:10 Mark Peek, @.***> wrote:
@sid21rane https://github.com/sid21rane LabelMatchStatement is included in this PR via StatementOne, StatementTwo and StatementThree properties. These are used due to the circular definitions in WAFv2 and are implemented per AWS::WAFv2::RuleGroup Statement https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-webacl-statement.html .
— Reply to this email directly, view it on GitHub https://github.com/cloudtools/troposphere/pull/1996#issuecomment-1003080953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXCXQNNPET3Y4HUFCCSKIWTUTR4NDANCNFSM5K6UCCHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
markpeek
commented
2 years ago @sid21rane yes, as I commented above LabelMatchStatement is already in each of those classes for this PR.
markpeek
commented
2 years ago Oh, sorry, misunderstood your request. WebACL and RuleGroup use a common set of Statements so it is already there. There are additions to the WebACL version which I took care of this morning.
sid21rane
commented
2 years ago Great then. Thanks Mark. When can we expect the PR to go live?
Regards, Siddharth Rane
On Thu, 30 Dec 2021, 23:58 Mark Peek, @.***> wrote:
@sid21rane https://github.com/sid21rane yes, as I commented above LabelMatchStatement is already in each of those classes for this PR.
— Reply to this email directly, view it on GitHub https://github.com/cloudtools/troposphere/pull/1996#issuecomment-1003137843, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXCXQNKCSW6QSMCLD23JQUDUTSQE5ANCNFSM5K6UCCHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
sid21rane
commented
2 years ago Thanks for the changes Mark, can see the attribute now on the doc. Appreciate it.
regards, Siddharth Rane
On Fri, Dec 31, 2021 at 12:52 AM Mark Peek @.***> wrote:
Merged #1996 https://github.com/cloudtools/troposphere/pull/1996 into main.
— Reply to this email directly, view it on GitHub https://github.com/cloudtools/troposphere/pull/1996#event-5828911403, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXCXQNNCC7BTDBRH4Q2FFGTUTSWOZANCNFSM5K6UCCHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Here is a first pass at auto-generating WAFv2. Wanted to get some input on this change as there were quite a few backward compatibility changes needed along with some removed properties and changes to required fields.
@dalgarin @jerry153fish @axelpavageau @marksidell