AWS::Lambda::Function ImageConfig EntryPoint is Type: List of String while troposphere is Str

cloudtools / troposphere

troposphere - Python library to create AWS CloudFormation descriptions

BSD 2-Clause "Simplified" License

4.93k stars 1.45k forks source link

AWS::Lambda::Function ImageConfig EntryPoint is Type: List of String while troposphere is Str #2008

Closed evilensky closed 2 years ago

evilensky commented 2 years ago

I think this is defined here? https://github.com/cloudtools/troposphere/blob/main/troposphere/awslambda.py#L287 Would it makes sense to change this definition to List?

markpeek commented 2 years ago

Looking at both 3.2.2 and 4.0.0-beta.0, this is defined as [str] which means a list of strings. This matches the AWS documentation. Do you have an example that doesn't work?

>>> from troposphere.awslambda import ImageConfig
>>> ImageConfig(EntryPoint=["string1", "string2"]).to_dict()
{'EntryPoint': ['string1', 'string2']}

evilensky commented 2 years ago

Edit: Sorry again for wasting your time!

markpeek commented 2 years ago

Going from Python 2.x to 3.x with troposphere 3.x should be fairly straightforward. Just check out these breaking changes.