cloudtools / troposphere

troposphere - Python library to create AWS CloudFormation descriptions
BSD 2-Clause "Simplified" License
4.93k stars 1.45k forks source link

An example of SNS alert for failed batch job events #2069

Closed rayjan0114 closed 2 years ago

rayjan0114 commented 2 years ago

Extend the official tutorial to be more close to production, the original tutorial is located at: https://docs.aws.amazon.com/batch/latest/userguide/batch_sns_tutorial.html

This example would send a successful job every 1 minute and failed job every 3 minutes and the failed jobs would invoke the lambda function through SNS.

markpeek commented 2 years ago

Thank you for the PR. I already know this will fail the tests as you need to add the output into tests/examples_output/BatchEventSnsLambda.template to verify the output when the tests are run. Also, be sure to run black and isort on the python file. Thanks!

rayjan0114 commented 2 years ago

OK, got it, I will fix it

rayjan0114 commented 2 years ago

Thanks for the feedback @markpeek

I have done the following checks

Please let me know if there is anything else, thanks

markpeek commented 2 years ago

@rayjan0114 Thank you for the PR and making the updates.