cloudtools / troposphere

troposphere - Python library to create AWS CloudFormation descriptions
BSD 2-Clause "Simplified" License
4.93k stars 1.45k forks source link

Add redshiftserverless.py module #2101

Closed tnielsen2 closed 1 year ago

tnielsen2 commented 1 year ago
markpeek commented 1 year ago

@tnielsen2 I'll have to review my contributing guides but I think you've figured it out. Basic flow is:

# download latest spec files
make spec
# generate the new troposphere file
./scripts/gen.py redshiftserverless > troposphere/redshiftserverless.py
# do black and isort fixups
make fix
tnielsen2 commented 1 year ago

Thanks @markpeek!

markpeek commented 1 year ago

Oh, and I should add running:

# run tests
make test
# run the linters
make lint
tnielsen2 commented 1 year ago

I had issues running make lint test on my machine. Namely because I was missing NPM/NPX and due to another (likely) venv issue. I don't recall seeing any info on NPM as a pre-req for this, but I figured I would mention it anyway!

markpeek commented 1 year ago

Thanks!