cloudtools / troposphere

troposphere - Python library to create AWS CloudFormation descriptions
BSD 2-Clause "Simplified" License
4.93k stars 1.45k forks source link

RDS support for GP3 disk type #2123

Closed LorenzoPintore closed 1 year ago

LorenzoPintore commented 1 year ago

Hi,

from the AWS Cloudformation documentation it is possibile now to create RDS DB instances with volume type gp3, gp2, io1 and standard. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbinstance.html#cfn-rds-dbinstance-storagetype Here the news from AWS: https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-rds-general-purpose-gp3-storage-volumes/ Looking in the troposphere source code under troposphere/validators/rds.py, there's the validate_storage_type function which is restricting the valid volume type only to standard, io1, gp2. It would be necessary to extend the list of valid volume types by also including gp3.

Thanks, Lorenzo

markpeek commented 1 year ago

Fixed. Thanks.